Small bug in import Holiday function: Always shows "deleted entries" in log although nothing was deleted


Domino/Notes Version: up until 14.5FP1


Problem/Query:

The agent “ImportHolidays“ in the default template has an annoying little bug in the result window. When you import holidays it will always show “x entries deleted” if you have “old” entries in your holiday profile that have been removed manually from your database (or e.g. by archiving).

This is caused by the function “MarkStrandedEntries” that identifies these documents and sets the corresponding value in the array to LotusScript True:

Me.m_vDeletedByAgent(n) = Cint(True)

Unfortunately later the function “ScanForDeletes” compares this value to 1:

If Not Cint(Me.m_vDeletedByAgent(n)) = 1 Then

As True equals -1 and -1 <> 1 the code tries to delete the (already deleted) entries and counts them as m_nDeleted and this results in the deletions being reported on every run.

This is easily fixable by changing the line above in:

Me.m_vDeletedByAgent(n) = 1 'instead of Cint(True)

This is not big enough of an issue to create a ticket for it, but probably one can pick it up here and let it be fixed in some later version of the mail template

Are there any HCL support people in here to pick this up and give that to template development or will this be ignored until a customer really opens a ticket for this (minor) issue?

Hi Tode,

Thank you for bringing this issue to our attention. Don’t worry—I have created an SPR for the ImportHolidays agent. When importing holidays, it will always show “x entries deleted.”

Please track further updates using SPR# PJEADMYTUW in our SPR database.

Regards,
PJ